update to all tests that used annotation_submit_fn #327
Conversation
tests/integration/conftest.py
Outdated
| client, project.uid, f'label-import-{uuid.uuid4()}', predictions) | ||
| upload_task.wait_until_done() | ||
| labels = annotation_submit_fn(project.uid, data_row.uid) | ||
| labels = [label.uid for label in project.labels()][0] |
There was a problem hiding this comment.
why only the zeroth index?
There was a problem hiding this comment.
configured_project_with_label used to only return 1 id in the labels var, so the test that used it did this:
model_run.upsert_labels([label_id])
i can change the test itself to just take in (label_id) instead of ([label_id]) if that makes more sense, and to keep labels as the whole list
There was a problem hiding this comment.
actually looking at how the asserts are set up, it looks like it does expect it to just be one. let me know if i should change the asserts to account for multiple labels too, or if leaving it as the 0th index is okay
There was a problem hiding this comment.
ohh I was mislead by the variable name. labels is just a single label. Ok then you can just do:
label = next(project.labels()).uid
yield [project, label]
That way it won't confuse people in the future
tests/integration/conftest.py
Outdated
| upload_task.wait_until_done() | ||
| labels = annotation_submit_fn(project.uid, data_row.uid) | ||
| labels = [label.uid for label in project.labels()][0] | ||
| time.sleep(3) |
There was a problem hiding this comment.
You can scrap this sleep timer
No description provided.