[AL-2619] Add 'metadata' field representing data row metadata as DataRowMetadat… #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msokoloff1
reviewed
Jun 15, 2022
labelbox/orm/db_object.py
Outdated
| elif isinstance(field.field_type, Field.EnumType): | ||
| value = field.field_type.enum_cls(value) | ||
| elif isinstance(field.field_type, | ||
| Field.ListType) and field.name == "metadata": |
Contributor
There was a problem hiding this comment.
I would check the list type of the field instead of the field name.
Contributor
Author
There was a problem hiding this comment.
That was my first version, but was getting a circular import issue when importing DataRowMetadataField :(
Let me look for a way to resolve the circular import, and if not, I could compare the list type against the "DataRowMetadataField" string
Contributor
|
Just one small nit. Otherwise looks good. I hate having to support metadataFields but I don't think that there is a better option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…aFields