[AL-2996] Fix metadata uploads with local file datarow upload #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kkim-labelbox
commented
Jul 26, 2022
kkim-labelbox
commented
- Fixed metadata not uploading when data row is a local file
- Added test cases
msokoloff1
reviewed
Jul 26, 2022
Comment on lines
+263
to
+266
| item['row_data'] = item_url | ||
| if 'external_id' not in item: | ||
| # Default `external_id` to local file name | ||
| item['external_id'] = row_data |
Contributor
Author
There was a problem hiding this comment.
it uses the original item, and alters it, rather than constructing a brand new item
Contributor
There was a problem hiding this comment.
What is the need for this? Or reasoning behind this change.
Contributor
There was a problem hiding this comment.
oh sorry, I should have read the description.
Contributor
Author
There was a problem hiding this comment.
No worries, it's a subtle change haha
jtsodapop
reviewed
Jul 26, 2022
labelbox/schema/dataset.py
Outdated
| def upload_if_necessary(item): | ||
| row_data = item['row_data'] | ||
| if os.path.exists(row_data): | ||
| item_url = self.client.upload_file(item['row_data']) |
Contributor
There was a problem hiding this comment.
suggestion can we change this item_url = self.client.upload_file(item['row_data']) to this?
item_url = self.client.upload_file(row_data)
jtsodapop
approved these changes
Jul 26, 2022
msokoloff1
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.