Skip to content

[AL-3872] Fix SDK build tests #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 14, 2022
Merged

[AL-3872] Fix SDK build tests #724

merged 3 commits into from
Oct 14, 2022

Conversation

@kkim-labelbox
Copy link
Contributor

@kkim-labelbox kkim-labelbox commented Oct 14, 2022 •
edited
Loading

  • Changed failed_data_rows to a property
  • Fixed issue with task always reporting warning, due to a bug with failed_data_rows check condition
  • Fixed test_create_data_rows_with_invalid_metadata on assertions
  • Fixed test_get_data_row_ids_for_invalid_global_keys to not falsely report PARTIAL SUCCESS
  • Fixed test_task_errors on assertions

@kkim-labelbox kkim-labelbox merged commit a1f0b4d into develop Oct 14, 2022
@kkim-labelbox kkim-labelbox deleted the kkim/AL-3872 branch October 14, 2022 21:52
@kkim-labelbox kkim-labelbox restored the kkim/AL-3872 branch October 14, 2022 22:07
@lhriley lhriley deleted the kkim/AL-3872 branch September 1, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkozik-lb mkozik-lb mkozik-lb approved these changes

@jakubborowski-lb jakubborowski-lb Awaiting requested review from jakubborowski-lb

@jtsodapop jtsodapop Awaiting requested review from jtsodapop

@msokoloff1 msokoloff1 Awaiting requested review from msokoloff1

@olegtrygub olegtrygub Awaiting requested review from olegtrygub

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kkim-labelbox @mkozik-lb