fix coco invalid polygons #728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 19, 2022 13:29
| categories[annotation.name] = hash_category_name(annotation.name) | ||
| if isinstance(annotation.value, Mask): | ||
| segment, canvas = (mask_to_coco_segment_info( | ||
| coco_segment_info = mask_to_coco_segment_info( |
Contributor
There was a problem hiding this comment.
Questions around this.
- How can coco_segment_info be set to
segment, canvaswhen it's only returningSegmentInfoobject? - When can coco_segment_info be None?
Contributor
Author
There was a problem hiding this comment.
- mask_to_coco_segment_info returns both of those things. It is hard to read because canvas looks like it is part of the SegmentInfo object but it isn't
- coco_segment_info can be None if the annotation is invalid. Like an empty seg mask is exported for whatever reason.
…into ms/coco-invalid-polygons
kkim-labelbox
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a small chance that our algorithm for creating polygons from rasters creates small self intersections. Ultimately these polygons become invalid and errors are thrown when we attempt to use the invalid polygons.