Skip to content

Conversation

@tytalus
Copy link
Contributor

@tytalus tytalus commented Oct 20, 2022

#Description
Fixing data row tests as part of the new import mechanism

@tytalus tytalus requested a review from kkim-labelbox October 20, 2022 16:15
Copy link
Contributor

@kkim-labelbox kkim-labelbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kkim-labelbox
Copy link
Contributor

kkim-labelbox commented Oct 20, 2022

Looks like the tests are failing on formatting
You can run this to fix it.

yapf tests labelbox -i --verbose --recursive --parallel --style "google"

In the long run, you can set up pre-commit to not worry about running yapf every time

install and activate [pre-commit](https://pre-commit.com/)

You'll need .pre-commit-config.yaml with this

repos:
  - repo: https://github.com/google/yapf
    rev: v0.31.0
    hooks:
      - id: yapf
        name: "yapf"
        args: [-i, --style, google]

@tytalus
Copy link
Contributor Author

tytalus commented Oct 21, 2022

Looks like the tests are failing on formatting You can run this to fix it.

yapf tests labelbox -i --verbose --recursive --parallel --style "google"

In the long run, you can set up pre-commit to not worry about running yapf every time

install and activate [pre-commit](https://pre-commit.com/)

You'll need .pre-commit-config.yaml with this

repos:
  - repo: https://github.com/google/yapf
    rev: v0.31.0
    hooks:
      - id: yapf
        name: "yapf"
        args: [-i, --style, google]

nice!

@tytalus tytalus merged commit 0dfb3f4 into develop Oct 21, 2022
@tytalus tytalus deleted the eg/fixing-tests branch October 21, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants