[AL-0] Polishing some sdk tests #732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msokoloff1
reviewed
Oct 21, 2022
|
|
||
|
|
||
| @pytest.mark.skipif(os.environ.get("DA_GCP_LABELBOX_API_KEY") is None, | ||
| @pytest.mark.skipif(os.environ.get("DA_GCP_LABELBOX_API_KEY") == "", |
Contributor
There was a problem hiding this comment.
This should be:
@pytest.mark.skipif(os.environ.get("DA_GCP_LABELBOX_API_KEY"))
That way this test doesn't run if either the env var is not set or if it is set to an empty string.
Contributor
Author
There was a problem hiding this comment.
skipif only accepts boolean as the condition, so I am doing not os.environ.get("DA_GCP_LABELBOX_API_KEY") instead, which should evaluate to false for empty string and None
Contributor
Author
There was a problem hiding this comment.
Good call nonetheless!
msokoloff1
approved these changes
Oct 24, 2022
gszpak
approved these changes
Oct 24, 2022
…into kkim/polish-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.