Skip to content

Conversation

@ovalle15
Copy link
Contributor

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ramy1951
Copy link
Contributor

@ovalle15 Nice work here Andrea! Just making sure here, did you mean to leave the colab and github links linked to the older version of this notebook?

Open In Colab GitHub

@ovalle15 ovalle15 changed the title Update queue_management Update queue_management - new paradigm Oct 28, 2022
@ovalle15
Copy link
Contributor Author

@ramy1951 but the location of the files is not going to change. We are just replacing content. The links will be pointing to the same file we are modifying, right?

@ovalle15
Copy link
Contributor Author

@ramy1951 tests are failing I am assuming that the commit can't be merged if those tests don't pass right?

@ovalle15
Copy link
Contributor Author

ovalle15 commented Nov 1, 2022

@msokoloff1 Do we need to update the colab notebook links (links below the labelbox logo), those links should be the same correct? since we are not changing the location of the original notebook ?

out of scope ? I can add to my to-do list how to set a benchmark label
@msokoloff1
Copy link
Contributor

yeah you don't need to update any of those links

@msokoloff1 msokoloff1 self-requested a review November 2, 2022 19:16
@msokoloff1 msokoloff1 merged commit ff2d2ec into develop Nov 2, 2022
@msokoloff1 msokoloff1 deleted the ovalle15-patch-1 branch November 2, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants