Skip to content

Update video image import - new paradigm #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 2, 2022
Merged

Update video image import - new paradigm #749

merged 2 commits into from
Nov 2, 2022

Conversation

@ovalle15
Copy link
Contributor

@ovalle15 ovalle15 commented Oct 28, 2022

No description provided.

@review-notebook-app
Copy link

review-notebook-app bot commented Oct 28, 2022

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@ovalle15 ovalle15 changed the title Update video image import Update video image import - new paradigm Oct 28, 2022
msokoloff1
msokoloff1 reviewed Nov 1, 2022
View reviewed changes
@msokoloff1
Copy link
Contributor

msokoloff1 commented Nov 1, 2022

I just had some nits around this. But one thought is that it would be good to include classifications in the video docs. I am asked about this every so often and there is no official example to point to.

@ovalle15
Latest updates
540e5cc 
1. Remove "s" from uploads 
2. Remove list from inside list comprehension
@ovalle15
Copy link
Contributor Author

ovalle15 commented Nov 1, 2022 •
edited
Loading

@msokoloff1 I agree, our thinking was that for the new paradigm release, we should make the most important updates. I could go back after the initial release and either create more complicated examples (new colabs) or update this one. What do you think?
I have a list of notebooks that I want to update - updates outside the new paradigm release, and a list of new notebooks I want to create, like a video mal based frame classification.

@msokoloff1 msokoloff1 self-requested a review November 2, 2022 19:32
msokoloff1
msokoloff1 approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@msokoloff1 msokoloff1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Adding more complex examples at a later time is fine.

@msokoloff1 msokoloff1 merged commit 29da652 into develop Nov 2, 2022
@msokoloff1 msokoloff1 deleted the ovalle15-patch-7 branch November 2, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@msokoloff1 msokoloff1 msokoloff1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ovalle15 @msokoloff1