Skip to content

[AL-4416] Increase DataRow limits to 150000 #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 21, 2022
Merged

[AL-4416] Increase DataRow limits to 150000 #809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
716d336
Increase data row import limits
Dec 20, 2022
b2882ed
Fix limits to 150,000
Dec 20, 2022
45f2f1a
Add CHANGELOG
Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
### Added
* Added `get_by_name()` method to MetadataOntology object to access both custom and reserved metadata by name.

### Changed
* `Dataset.create_data_rows()` max limit of DataRows increased to 150,000

# Version 3.33.1 (2022-12-14)
### Fixed
* Fixed where batch creation limit was still limiting # of data rows. SDK should now support creating batches with up to 100k data rows
Expand Down
12 changes: 1 addition & 11 deletions labelbox/schema/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@

logger = logging.getLogger(__name__)

MAX_DATAROW_PER_API_OPERATION = 150000
MAX_DATAROW_WITH_METADATA = 30000
MAX_DATAROW_PER_API_OPERATION = 150_000


class Dataset(DbObject, Updateable, Deletable):
Expand Down Expand Up @@ -426,15 +425,6 @@ def convert_item(item):
f"Cannot create more than {MAX_DATAROW_PER_API_OPERATION} DataRows per function call."
)

# TODO: If any datarows contain metadata, we're limiting max # of datarows
# until we address performance issues with datarow create with metadata
if len(items) > MAX_DATAROW_WITH_METADATA:
for row in items:
if 'metadata_fields' in row:
raise MalformedQueryException(
f"Cannot create more than {MAX_DATAROW_WITH_METADATA} DataRows, if any DataRows contain metadata"
)

with ThreadPoolExecutor(file_upload_thread_count) as executor:
futures = [executor.submit(convert_item, item) for item in items]
items = [future.result() for future in as_completed(futures)]
Expand Down