New NDJSON format - tile imagery #817
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -38,34 +38,52 @@ | |||
| }, | |||
There was a problem hiding this comment.
| @@ -38,34 +38,52 @@ | |||
| }, | |||
There was a problem hiding this comment.
One thing that is lost in these updates is the tools for geospatial transformations. Here you have hard coded all of the object coordinates. But almost every ML engineer has to either start with a model prediction and project into wgs84 coordinates or start with labels and project into pixels. imo these tools are super cool and there is no great open source alternative. Even if the main point of the notebook isn't to do the projection we should highlight it.
Reply via ReviewNB
There was a problem hiding this comment.
I see, this will require a bit more work. Can I suggest demonstrating the geospatial transformations on a different notebook ?
There was a problem hiding this comment.
@msokoloff1 do you think creating a new notebook that only focuses on geospatial transformations could work? Otherwise, the current notebook would be too complex, in my opinion.
There was a problem hiding this comment.
Done. ! Included a polygon transformation on Step 1 below.
There was a problem hiding this comment.
Moved this to step 5
| @@ -38,34 +38,52 @@ | |||
| }, | |||
There was a problem hiding this comment.
Line #22.
I don't think this is necessary any more. I think it uploads in-line. Please double check if this is needed.
Reply via ReviewNB
1. Removed unused imports 2. Removed signing function 3. Updated file path
Included CV2 and PIL python libraries to generate the polygon annotation
| @@ -20,12 +20,12 @@ | |||
| }, | |||
There was a problem hiding this comment.
| @@ -20,12 +20,12 @@ | |||
| }, | |||
There was a problem hiding this comment.
from labelbox.schema.ontology import OntologyBuilder, Tool, Classification, Option from labelbox import Client, LabelingFrontend, LabelImport, MALPredictionImport
These are all available in the top level namespace.
Reply via ReviewNB
| @@ -20,12 +20,12 @@ | |||
| }, | |||
There was a problem hiding this comment.
Line #4. import cv2
These are duplicates. I would just add all imports at the top.
Reply via ReviewNB
Modified order of the cell with polygon 2 annotation
No description provided.