-
Notifications
You must be signed in to change notification settings - Fork 68
[AL-4397] Add project & data row import v2 #841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
842a50f to
dc6b748
Compare
e8bc0dd to
0b2ec06
Compare
d234cad to
d91c864
Compare
09ec94f to
27a5cde
Compare
639501c to
dc7d985
Compare
41144ce to
22052df
Compare
4863f15 to
32c30f2
Compare
b3a3de4 to
e391e74
Compare
e391e74 to
5a02954
Compare
5a02954 to
7506bd0
Compare
4145771 to
32fe56e
Compare
msokoloff1
approved these changes
Feb 2, 2023
msokoloff1
reviewed
Feb 2, 2023
| params: Optional[ProjectExportParams]) -> Task: | ||
| defaultParams: ProjectExportParams = { | ||
| "attachments": False, | ||
| "media_attributes": False, |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This always is requested. So let's remove it from the params.
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix in a follow up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.