Skip to content

[AL-4767] Deprecation notice for deletedDataRowGlobalKeys portion of results in… #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2023
Merged

[AL-4767] Deprecation notice for deletedDataRowGlobalKeys portion of results in… #859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions labelbox/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1159,6 +1159,10 @@ def get_data_row_ids_for_global_keys(
"""
Gets data row ids for a list of global keys.

Deprecation Notice: This function will soon no longer return 'Deleted Data Rows'
as part of the 'results'. Global keys for deleted data rows will soon be placed
under 'Data Row not found' portion.

Args:
A list of global keys
Returns:
Expand Down Expand Up @@ -1243,6 +1247,13 @@ def _format_failed_rows(rows: List[str],
"There are errors present. Please look at 'errors' in the returned dict for more details"
)

# Deprecation notice for deletedDataRowGlobalKeys portion of results
if len(data['deletedDataRowGlobalKeys']) > 0:
logger.warning(
"""Deprecation Notice: This function will soon no longer return 'Deleted Data Rows'
as part of the 'results'. Global keys for deleted data rows will soon be placed under
'Data Row not found' portion.""")

return {"status": status, "results": results, "errors": errors}
elif res["dataRowsForGlobalKeysResult"]['jobStatus'] == "FAILED":
raise labelbox.exceptions.LabelboxError(
Expand Down