[AL-4919] Make params optional, add task result to export task type #876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnoszczak
force-pushed
the
mno/x-0-fix-default-values
branch
from
46265d4 to
c5bc124
Compare
msokoloff1
reviewed
Feb 6, 2023
labelbox/schema/model_run.py
Outdated
| _params = params or {} | ||
| def export_v2(self, | ||
| task_name: Optional[str] = None, | ||
| params: Optional[ModelRunExportParams] = {}) -> Task: |
Contributor
There was a problem hiding this comment.
Assigning a default argument of a dict is bad practice. It isn't re-defined for each function invokation, only when the function is defined.
Technically you aren't modifying this so it should be fine. Also, optional means default value of None - not that it has a default.
I would revert back to how you have it. But just set the value to None by default.
mnoszczak
force-pushed
the
mno/x-0-fix-default-values
branch
from
2cfcc56 to
2cfd661
Compare
mnoszczak
changed the title
mnoszczak
force-pushed
the
mno/x-0-fix-default-values
branch
2 times, most recently
from
99bb8b9 to
002d5d9
Compare
mnoszczak
force-pushed
the
mno/x-0-fix-default-values
branch
from
002d5d9 to
b1c55c2
Compare
msokoloff1
reviewed
Feb 9, 2023
|
|
||
|
|
||
| @pytest.mark.skip(reason="feature under development") | ||
| # @pytest.mark.skip(reason="feature under development") |
Contributor
There was a problem hiding this comment.
You can just delete this line instead of commenting it out
Contributor
There was a problem hiding this comment.
Although I think exports v2 is broken in staging right now.. Maybe leave this until it is more stable.
msokoloff1
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.