[AL-4986] Filter skipped labels for project with videos in label_generator() #912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulnoirel
changed the title
msokoloff1
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the issue where exporting a project that contains both videos data rows and skipped labels with
label_generator()throws the error:ValueError: Found mixed data types of video and text/image. Use project.export_labels() to export projects with mixed data types.Actions:
To prevent this from happening, the patch filters on skipped labels when looking for videos in the export.
To prevent the error
Can't infer data type from row data, the patch filters the skipped labels because the call toBV1Converter.deserialize_videoNote:
Due to this change, the output of
len(list(project.label_generator()))andlen(project.export_labels())will be different for projects with both videos and skipped labels.