Vb/depr label list sprnew 4863 2 #913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
vbrodsky
force-pushed
the
VB/depr-label-list_SPRNEW-4863_2
branch
3 times, most recently
from
51a3c5e to
3670872
Compare
added 2 commits
February 16, 2023 14:52
Remove LabelList from text.ipynb Remove LabelList from getting_started.ipynb Remove LabelList from coco_object.ipynb Remove LabelList from coco_panoptic.ipynb Remove LabelList from images.ipynb Remove LabelList from custom_metrics_demo.ipynb Remove LabelList from model_diagnostics_demo.ipynb
vbrodsky
force-pushed
the
VB/depr-label-list_SPRNEW-4863_2
branch
from
3670872 to
b20be1b
Compare
Contributor
kkim-labelbox
left a comment
kkim-labelbox
left a comment
There was a problem hiding this comment.
Looks like there's a few more places referring to LabelList inside comments or error messages.
group.py
converter.py
objects.py
base.py
test_collection_py
test_metrics.py
Could we also remove reference to LabelList in all these places?
Contributor
Author
|
I did not address py classes in this PR, created a separate task https://labelbox.atlassian.net/browse/AL-4965 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://labelbox.atlassian.net/browse/AL-4863
This PR deprecates
LabelListandLabelGenerator#as_string()in notebooksNOTE: I have tested all note books locally, except for those that I changed and are listed in https://labelbox.atlassian.net/browse/AL-4905:
Ran the
nbqa mypy examples | grep name-definedutility