New methods to manage feature schemas and ontologies #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgluszek
changed the title
lgluszek
commented
Feb 27, 2023
| ) | ||
|
|
||
|
|
||
| def test_deletes_a_feature_schema(client): |
Contributor
Author
There was a problem hiding this comment.
Decided to not use fixtures for tests, because the feature schema class does not have a "deletable" interface. Schema nodes have a "deleted" property, but we can't create such fixtures.
Contributor
There was a problem hiding this comment.
Looks a lot better! Thanks for adding all of the tests too.
Left one comment, and also, it'd be great if you could add return types for functions. For "delete" functions, you can add None as return type.
Also, the build is failing. Could you try rebasing the latest develop branch and try the build again? There were some recent fixes to export related tests, and I wonder if your branch is stale
labelbox/client.py
Outdated
| "Failed to update the feature schema, message: " + | ||
| str(response.json()['message'])) | ||
|
|
||
| def upsert_feature_schema(self, normalized: Dict): |
Contributor
There was a problem hiding this comment.
- Could you name it something more descriptive than
normalized? I think what you had before was fine:feature_schema. Now it's more obvious what type of data is needed, with the type hint. Let's also add a description of what this dictionary should be, in the docstring:
feature_schema: Dict representing the feature schema to upsert
labelbox/client.py
Outdated
| "Failed to delete the ontology, message: " + | ||
| str(response.json()['message'])) | ||
|
|
||
| def update_feature_schema_title(self, feature_schema_id: str, title: str): |
labelbox/client.py
Outdated
| "Failed to update the feature schema, message: " + | ||
| str(response.json()['message'])) | ||
|
|
||
| def upsert_feature_schema(self, feature_schema: Dict): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://labelbox.atlassian.net/browse/PTDT-1109
https://labelbox.atlassian.net/browse/PTDT-1110
https://labelbox.atlassian.net/browse/PTDT-1112
https://labelbox.atlassian.net/browse/PTDT-1113
https://labelbox.atlassian.net/browse/PTDT-1131
https://labelbox.atlassian.net/browse/PTDT-1132
Introduced 7 new methods: