[AL-5172] Global key support for Annotation Types #986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrodsky
approved these changes
Mar 12, 2023
| return v | ||
| @root_validator() | ||
| def must_set_one(cls, values): | ||
| if bool(values.get('id')) == bool(values.get('global_key')): |
Contributor
There was a problem hiding this comment.
Suggested change
| if bool(values.get('id')) == bool(values.get('global_key')): | |
| if bool(values.get('id')) == bool(values.get('global_key')) == None: # to be on a safe side |
Contributor
There was a problem hiding this comment.
Since this logic can be a little tricky to read, might want to create a util function that describes what it does, e.g. is_exactly_one_set(values.get('id'), values.get('global_key'))
…into kkim/AL-5172
whistler
reviewed
Mar 13, 2023
| return v | ||
| @root_validator() | ||
| def must_set_one(cls, values): | ||
| if bool(values.get('id')) == bool(values.get('global_key')): |
Contributor
There was a problem hiding this comment.
Since this logic can be a little tricky to read, might want to create a util function that describes what it does, e.g. is_exactly_one_set(values.get('id'), values.get('global_key'))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.