[AL-5107] Vb/conversational annotation al 5107 2 #996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrodsky
force-pushed
the
VB/conversational-annotation_AL-5107_2
branch
5 times, most recently
from
7ba4a76 to
0d0a967
Compare
Contributor
kkim-labelbox
left a comment
kkim-labelbox
left a comment
There was a problem hiding this comment.
Left some comments. Also, I see that DocumentEntity has a name field, which doesn't seem necessary, since ObjectAnnotation already has a name tied to it. Could you make that change in this PR as well? Will probably need to update the tests as well
| def test_conversation_entity(client, configured_project_without_data_rows, | ||
| dataset_conversation_entity, rand_gen): | ||
|
|
||
| conversation_entity_annotation = ConversationEntity(name="named-entity", |
Contributor
There was a problem hiding this comment.
Don't think you need name here, since the name is set in ObjectAnnotation
whistler
reviewed
Mar 15, 2023
vbrodsky
force-pushed
the
VB/conversational-annotation_AL-5107_2
branch
2 times, most recently
from
86a60dd to
3f3a7a1
Compare
vbrodsky
force-pushed
the
VB/conversational-annotation_AL-5107_2
branch
2 times, most recently
from
45991f5 to
85a3612
Compare
vbrodsky
force-pushed
the
VB/conversational-annotation_AL-5107_2
branch
from
85a3612 to
3527c81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
story: https://labelbox.atlassian.net/browse/AL-5107