[AL-5108] Add DICOM polyline annotation kind #999
Conversation
vbrodsky
left a comment
vbrodsky
left a comment
There was a problem hiding this comment.
minor comments and questions
| >>> ]), | ||
| >>> segment_index=0, | ||
| >>> keyframe=True, | ||
| >>> Group_key=GroupKey.AXIAL |
There was a problem hiding this comment.
if you want to be really precise here, add confidence too
There was a problem hiding this comment.
VideoObjectAnnotation uses the ConfidenceNotSupportedMixin, so I assume confidence is not supported for this yet.
| data: Union[VideoData, ImageData, TextData, TiledImageData] | ||
| annotations: List[Union[ClassificationAnnotation, ObjectAnnotation, | ||
| VideoObjectAnnotation, | ||
| DICOMObjectAnnotation, VideoObjectAnnotation, |
There was a problem hiding this comment.
here is my question: for some cases, a type here is a base class, like ObjectAnnotation and I think derived classes are going in, am I right? But now you are adding DICOMObjectAnnotation.
There was a problem hiding this comment.
Good catch, I just added DICOMObjectAnnotation for completeness since I saw other video annotation types listed there. But I think just the base classes are enough, so I've removed all Video/DICOM subclasses from here.
whistler
force-pushed
the
imuhammad/AL-5108-dicom-polyline
branch
from
d40412f to
13509f2
Compare
whistler
force-pushed
the
imuhammad/AL-5108-dicom-polyline
branch
from
13509f2 to
93b169d
Compare
DICOMObjectAnnotationandGroupKeyenum to support annotation import using Python objects.NDJsonConverterto serialize/deserializeDICOMObjectAnnotationto/from the NDJson format.Note: coco tests did not cleanup files written to directory which resulted in only the first execution of these tests working the and subsequent ones failing. These have been updated to cleanup temporary files.