LibWeb: Update HTMLMediaElements' playback positions when invisible

Zaggy1024 · gmta · commit 16b296c09023 · 2025-10-27T17:28:49.000-07:00
diff --git a/Libraries/LibWeb/HTML/HTMLMediaElement.cpp b/Libraries/LibWeb/HTML/HTMLMediaElement.cpp
@@ -1159,8 +1159,6 @@ void HTMLMediaElement::set_selected_video_track(Badge<VideoTrack>, GC::Ptr<HTML:
 
 void HTMLMediaElement::update_video_frame_and_timeline()
 {
-    if (!paintable())
-        return;
     if (!m_playback_manager)
         return;
 
@@ -1181,7 +1179,7 @@ void HTMLMediaElement::update_video_frame_and_timeline()
         needs_display = true;
     }
 
-    if (needs_display)
+    if (needs_display && paintable())
         paintable()->set_needs_display();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1159,8 +1159,6 @@ void HTMLMediaElement::set_selected_video_track(Badge<VideoTrack>, GC::Ptr<HTML:`
`1159`	`1159`
`1160`	`1160`	`void HTMLMediaElement::update_video_frame_and_timeline()`
`1161`	`1161`	`{`
`1162`		`- if (!paintable())`
`1163`		`- return;`
`1164`	`1162`	`if (!m_playback_manager)`
`1165`	`1163`	`return;`
`1166`	`1164`
`@@ -1181,7 +1179,7 @@ void HTMLMediaElement::update_video_frame_and_timeline()`
`1181`	`1179`	`needs_display = true;`
`1182`	`1180`	`}`
`1183`	`1181`
`1184`		`- if (needs_display)`
	`1182`	`+ if (needs_display && paintable())`
`1185`	`1183`	`paintable()->set_needs_display();`
`1186`	`1184`	`}`
`1187`	`1185`