[IMP] Decode decryption response #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add better documentation to `decrypt` * Decode aspects of the decrypt response to allow for more usable return
lasley
force-pushed
the
feature/master/decode-decrypt-response
branch
from
9731e30 to
3d9f7e2
Compare
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 86 90 +4
Branches 3 3
=====================================
+ Hits 86 90 +4
Continue to review full report at Codecov.
|
* Use the status instead of the response on error
tedsalmon
approved these changes
Apr 10, 2017
| # Copyright 2016-2017 LasLabs Inc. | ||
| # License MIT (https://opensource.org/licenses/MIT). | ||
|
|
||
| import json |
There was a problem hiding this comment.
Why import the entire library instead of what you're using? :)
from json import loads
There was a problem hiding this comment.
Shitty namespace of loads and dumps basically. import json.loads doesn't work either 😦
>>> import json.loads
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ImportError: No module named loads
| # Copyright 2016-2017 LasLabs Inc. | ||
| # License MIT (https://opensource.org/licenses/MIT). | ||
|
|
||
| import json |
There was a problem hiding this comment.
Same here, why not just import dumps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decrypt