Fix passing host to in headers #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
requested changes
Dec 24, 2024
Collaborator
auvipy
left a comment
auvipy
left a comment
There was a problem hiding this comment.
it would be nice to have some test added for the change proposed
auvipy
requested changes
Dec 24, 2024
Signed-off-by: Asif Saif Uddin <auvipy@gmail.com>
Contributor
Author
|
Ok, I've added a unit test for this, please check @auvipy 👀 |
auvipy
requested changes
Jan 29, 2025
Collaborator
auvipy
left a comment
auvipy
left a comment
There was a problem hiding this comment.
think we should also update the relevant docs, what do you think?
auvipy
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
WebSocketBaseClient, there is a hardcodedHostheader. This pull request will let it useHostin the passed in extra headers, and if it is not exists in extra headers, will use the origin logic to setHost.