Merged
Conversation
osuketh
reviewed
May 26, 2021
.env.sample
Outdated
| ETH_DOCKER_PORT=8545 | ||
| AZURITE_IP_ADDRESS=172.16.0.4 | ||
| AZURITE_HOST_PORT1=10000 | ||
| AZURITE_HOST_PORT2=10001 |
Member
There was a problem hiding this comment.
10001はキューリスニングポートだからいらない説
https://docs.microsoft.com/ja-jp/azure/storage/common/storage-use-azurite#queue-listening-port-configuration
10002はエミュレータに追加しているが何に使っているんだろう
Collaborator
Author
There was a problem hiding this comment.
:fmfm:
azuriteよくわからず機械的に環境変数化してしまったんですが、削ります？
10000だけあればよいのカナ
Member
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment.
10001 を爆破しつつ、環境変数名はblobとtableがわかるように命名し直します。
開発者ごとに割り振るポートも2つずつ（コンテナ内部からは10000と10002が見えるようにするので若干見づらいかもですが仕方ない）
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issueへのリンク
やったこと
.envで設定frame/azure-client/docker-compose.ymlは開発用なので、専用にポートを払い出し。かつハードコードした（.envからは読まないが専用なので被らない）やらないこと
test_blobの修正動作検証
参考