Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issueへのリンク
やったこと
やらないこと
動作検証
prd-signed.soを含んだ検証としてexample-erc20.Dockerfileがdocker buildできることを手動で確認参考
依存関係の整理について補足です。
処理の中で必要なものが
:の右に来るようにしています。例外は
T_O_FILEの生成で、処理で明示されるT_C_FILEがEnclave_EDL_Filesの最初の値というのがトリッキーです。これは標準出力と生成ファイルが一致するようにする方針を優先して例外としています。