Skip to content

refactor(compiler): isolate compilation #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025
Merged

refactor(compiler): isolate compilation #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
120cd16
refactor(compiler): isolate compilation
abdullah-wn Jan 23, 2025
38e7595
chore(compiler): add changeset
abdullah-wn Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/brave-forks-ring.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'babel-plugin-unisonjs-compiler': patch
---

Isolate compilation
212 changes: 106 additions & 106 deletions packages/compiler/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,142 +297,142 @@ export default function (babel, opts = {}) {
if (declaration.source.value === moduleName) {
for (const specifier of declaration.specifiers) {
if (specifier.local.name === UNISON_NAME) {
currentUnisonName = specifier.imported.name
currentUnisonName = specifier.imported.name;
this.hasUnison();
path.stop();
break;
}
}
}
},
};
};

let mode = opts.mode || 'manual';

const mainVisitor = {
FunctionDeclaration(path) {
// Looking for :
// function Component() {}; $unison(Component);
if (path.node.id && isComponentishName(path.node.id.name)) {
let isUnison = false;
program.traverse(isUnisonComponent, {
isUnison: () => void (isUnison = true),
idName: path.node.id.name,
});

if (noUnison(path.node.body.directives)) return;
if (!isUnison && (mode === 'full' || (mode === 'directive' && useUnison(path.node.body.directives)))) {
if (t.isExportDefaultDeclaration(path.parent)) {
// Convert to : const Component = $unison(function Component() {});
const varDec = path.parentPath.replaceWith(
t.variableDeclaration('const', [
t.variableDeclarator(
path.node.id,
t.callExpression(t.identifier(currentUnisonName), [
t.functionExpression(path.node.id, path.node.params, path.node.body),
]),
),
]),
)[0];

// add : export default Component;
varDec.insertAfter(t.exportDefaultDeclaration(path.node.id));
} else {
// export default Component;
path.replaceWith(
t.variableDeclaration(path.node.kind || 'const', [
t.variableDeclarator(
path.node.id,
t.callExpression(t.identifier(currentUnisonName), [
t.functionExpression(path.node.id, path.node.params, path.node.body),
]),
),
]),
);
}
}

if (isUnison) {
const componentBody = path.get('body');
optimizeComponent(componentBody);
}
}
},
VariableDeclaration(path) {
for (let i = 0; i < path.node.declarations.length; i++) {
const declaration = path.get(`declarations.${i}`);
const id = declaration.node.id;

if (id && isComponentishName(declaration.node.id.name)) {
if (t.isArrowFunctionExpression(declaration.node.init) || t.isFunctionExpression(declaration.node.init)) {
if (noUnison(declaration.node.init.body.directives)) return;
if (mode === 'full' || (mode === 'directive' && useUnison(declaration.node.init.body.directives))) {
declaration
.get('init')
.replaceWith(t.callExpression(t.identifier(currentUnisonName), [declaration.node.init]));
}
}

// It's not a unison component
//
if (
!t.isCallExpression(declaration.node.init) ||
!declaration.node.init.callee ||
declaration.node.init.callee.name !== currentUnisonName
) {
return;
}
const root = declaration.get('init');

const argument = root.get('arguments.0');
if (argument.isArrowFunctionExpression() || argument.isFunctionExpression()) {
const componentBody = argument.get('body');
optimizeComponent(componentBody);
alreadyOptimized.add(id.name);
toOptimize.delete(id.name);
}

if (argument.isIdentifier()) {
if (!alreadyOptimized.has(id.name)) {
toOptimize.add(id.name);
}
}
}
}
},
};

return {
name: 'unison-compiler',
visitor: {
Program: {
enter(path) {
program = path;
let unisonImported = false;
path.traverse(hasUnisonVisitor, { hasUnison: () => (unisonImported = true) });

let unisonImported = false
path.traverse(hasUnisonVisitor, { hasUnison: () => unisonImported = true });

if (!unisonImported) {
const id = t.identifier(UNISON_NAME)
const id = t.identifier(UNISON_NAME);
// add: import { $unison } from 'module_name';
program.unshiftContainer('body', [
t.importDeclaration(
[t.importSpecifier(id, id)],
t.stringLiteral(moduleName),
),
path.unshiftContainer('body', [
t.importDeclaration([t.importSpecifier(id, id)], t.stringLiteral(moduleName)),
]);
}

if (noUnison(path.node.directives)) path.stop();

if (mode === 'directive' && useUnison(path.node.directives)) {
mode = 'full';
path.get('directives.0').replaceWith(t.directive(t.directiveLiteral('use client')))
path.get('directives.0').replaceWith(t.directive(t.directiveLiteral('use client')));
}

if (rsxIdentifier) return;
rsxIdentifier = program.scope.generateUidIdentifier('rsx');
program.unshiftContainer('body', [
rsxIdentifier = path.scope.generateUidIdentifier('rsx');
path.unshiftContainer('body', [
t.importDeclaration([t.importSpecifier(rsxIdentifier, t.identifier('rsx'))], t.stringLiteral(moduleName)),
]);
},
},
FunctionDeclaration(path) {
// Looking for :
// function Component() {}; $unison(Component);
if (path.node.id && isComponentishName(path.node.id.name)) {
let isUnison = false;
program.traverse(isUnisonComponent, {
isUnison: () => void (isUnison = true),
idName: path.node.id.name,
});

if (noUnison(path.node.body.directives)) return;
if (!isUnison && (mode === 'full' || (mode === 'directive' && useUnison(path.node.body.directives)))) {
if (t.isExportDefaultDeclaration(path.parent)) {
// Convert to : const Component = $unison(function Component() {});
const varDec = path.parentPath.replaceWith(
t.variableDeclaration('const', [
t.variableDeclarator(
path.node.id,
t.callExpression(t.identifier(currentUnisonName), [
t.functionExpression(path.node.id, path.node.params, path.node.body),
]),
),
]),
)[0];

// add : export default Component;
varDec.insertAfter(t.exportDefaultDeclaration(path.node.id));
} else {
// export default Component;
path.replaceWith(
t.variableDeclaration(path.node.kind || 'const', [
t.variableDeclarator(
path.node.id,
t.callExpression(t.identifier(currentUnisonName), [
t.functionExpression(path.node.id, path.node.params, path.node.body),
]),
),
]),
);
}
}

if (isUnison) {
const componentBody = path.get('body');
optimizeComponent(componentBody);
}
}
},
VariableDeclaration(path) {
for (let i = 0; i < path.node.declarations.length; i++) {
const declaration = path.get(`declarations.${i}`);
const id = declaration.node.id;

if (id && isComponentishName(declaration.node.id.name)) {
if (t.isArrowFunctionExpression(declaration.node.init) || t.isFunctionExpression(declaration.node.init)) {
if (noUnison(declaration.node.init.body.directives)) return;
if (mode === 'full' || (mode === 'directive' && useUnison(declaration.node.init.body.directives))) {
declaration
.get('init')
.replaceWith(t.callExpression(t.identifier(currentUnisonName), [declaration.node.init]));
}
}

// It's not a unison component
//
if (
!t.isCallExpression(declaration.node.init) ||
!declaration.node.init.callee ||
declaration.node.init.callee.name !== currentUnisonName
) {
return;
}
const root = declaration.get('init');

const argument = root.get('arguments.0');
if (argument.isArrowFunctionExpression() || argument.isFunctionExpression()) {
const componentBody = argument.get('body');
optimizeComponent(componentBody);
alreadyOptimized.add(id.name);
toOptimize.delete(id.name);
}

if (argument.isIdentifier()) {
if (!alreadyOptimized.has(id.name)) {
toOptimize.add(id.name);
}
}
}
}
path.traverse(mainVisitor);
},
},
},
};
Expand Down
Loading