v2.2.3 fails to rewrite alias path in decleration file, reverted back to v2.2.1

[jacobbogers]

snippet from tsconfig.json file

 { "transform": "typescript-transform-paths", "afterDeclarations": true }

replacing path aliases in decleration files does not work in (current) version 2.2.3 (i reverted back to 2.2.1 and it works with this version)

[jacobbogers]

Oh in v 2.2.1 ... these 2 things are mutually exclusive, you cannot emit BOTH *.js and *.d.ts files with "transpile" paths aliases

Either you transpile paths in in emitted *.js files { "transform": "typescript-transform-paths" } OR you transpile path aliases in *.d.ts files { "transform": "typescript-transform-paths", "afterDeclarations": true }

but not both at the same time

[nonara]

Thanks for reporting the issue, Jacob!

Unfortunately, I'm not able to reproduce either condition you've described. I have no issue emitting both, and we have fairly comprehensive testing which covers that scenario as well as others. I've also looked at the difference between the versions, and I'm not seeing anything which could cause the sort of difference you've mentioned between the two versions, as the portions of code responsible for that logic haven't been altered.

I'm going to need a reproduction so I can dig into it further.

[jacobbogers]

Hi,
I am using the master branch (as of this writing) of https://github.com/jacobbogers/libRmath.js

Here are the steps for reproduction

Here is a reproduction, first let me show you the version numbers:

from package.json:

      "typescript-transform-paths": "^2.2.3"

from node_modules/typescript-transform-path/package.json

  "_requested": {
    "type": "version",
    "registry": true,
    "raw": "typescript-transform-paths@2.2.3",
    "name": "typescript-transform-paths",
    .
    .

tsconfig.json

 "plugins": [
     .
      {
        "transform": "typescript-transform-paths",
        "afterDeclarations": true
      }
     .
    ],

I am using the tsconfig-commonjs.json which extends the tsconfig.json

{
    "extends": "./tsconfig.json",
    "exclude":[
        "**/__test__"
    ],
    "compilerOptions": {
        "noEmit": false,
        "module": "CommonJS",
        "outDir": "commonjs",
        "target": "es2020",
        "declarationDir": "commonjs/types"
    }
}

Now run:

npx ttsc -p tsconfig-commonjs.json

the commonjs directory will have source and typings (in different dirs)

Example (i picked 2 files)

Lets look at the top of the js file commonjs\lib\distributions\cauchy.js

Path alias '@common/logger' is NOT translated

const debug_1 = require("debug");
const logger_1 = require("@common/logger");   // <--- NOT TRANSLATED!!
const { isNaN: ISNAN } = Number;
const { PI: M_PI, log } = Math;
const printer = debug_1.debug('dcauchy');

Lets look at a typings file commonjs\types\lib\distributions\cauchy\index.d.ts

Path alias '@rng/normal/normal-rng' is translated

export { dcauchy } from "./dcauchy";
export { pcauchy } from "./pcauchy";
export { qcauchy } from "./qcauchy";
import type { IRNGNormal } from "../../rng/normal/normal-rng";  // <--- TRANSLATED
export declare function rcauchy(n: number, location?: number, scale?: number, rng?: IRNGNormal): Float32Array;
//# sourceMappingURL=index.d.ts.map

[jacobbogers]

Was my previous post in any way helpfull?
Cheers

[nonara]

GH didn't send me an email on this, so I didn't see it until now.

It looks to me like you've not added both lines to the config file. If you want to translate for both js and types, you need two entries in plugins.

Essentially, the TS compiler is built so that JS and type definitions are two separate transform cycles being performed at different stages and, consequently, with different variants of the AST. The plugin needs to be fed in for each that you want it to intercept.

ie (for both):

    "plugins": [
      { "transform": "typescript-transform-paths" },
      { "transform": "typescript-transform-paths", "afterDeclarations": true }
    ]

Let me know if that helps!

[jacobbogers]

@nanora, superthanks, it works now, with the added line,
I thought that { "transform": "typescript-transform-paths", "afterDeclarations": true } was a superset of the first line (because of the extra afterDeclerations) Thanks for explaining to me about the seperate transform cycles.

Super

[nonara]

No problem. Glad it's working for you! Take care.