Skip to content

refactor: cleanup AST code #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LeanSerra merged 26 commits into from
Oct 29, 2025
Merged

refactor: cleanup AST code #32

LeanSerra merged 26 commits into from
Oct 29, 2025

Conversation

@LeanSerra
Copy link
Owner

@LeanSerra LeanSerra commented Oct 28, 2025 •
edited
Loading

Description

This PR refactors the code in src/grammar/rules_actions.rs to use let ast = &mut compiler_context.ast; as it reduced some noise added by having to use compiler_context.ast for every interaction with the AST

It removes some functions for push|pop out of the expression and term stacks as those fields are now public to be consistent with the way we use the other AST stacks

It also wraps the repeated code for log_error_and_exist into log_ast_error function

@LeanSerra
feat: AST generation for arithmetic expressions
8618bb2
@LeanSerra
fix: remove clone from Ast
10b9f99
@LeanSerra
ci: set rust toolchain to nightly
dd518f7
@LeanSerra
ci: set rust toolchain to nightly 1.91.0
ef7e251
@LeanSerra
ci: remove toolchain version from install rust step
0992a35
@LeanSerra
feat: graph AST with Graphviz
f1f46db
@LeanSerra
docs: update README.md with graphviz reference
002840b
@LeanSerra
docs: fix prerequisites list formatting
040e25e
@LeanSerra
fix: remove boolean chains (a<b<c) and fix conjunctions
e3769e7
@LeanSerra
feat: AST generation for booleanStatements and If
fc203fd
@LeanSerra
fix: else statements could be used before having an if before it
6b42e9c
@LeanSerra
feat: AST generation for else statements and nested ifs
f549d63
@LeanSerra
fix: reset body pointer on empty body
e597648
@LeanSerra
feat: AST generation for while statements
16cf44d
@LeanSerra
fix: var name in while_loop_while
6a18108
@LeanSerra
feat: AST generation for write io function
aabb950
@LeanSerra
feat: AST generation for read io function
7036d79
@LeanSerra
feat: AST support multiple statements in body
7a1021d
@LeanSerra
fix: handle errors for empty statement stack
0fed071
@LeanSerra
feat: AST support for convDate
70af0d4
@LeanSerra
feat: AST support for isZero
78c4418
@LeanSerra
feat: AST generation for Number
5508518
@LeanSerra
refactor: cleanup AST code
efb80e3
@LeanSerra
refactor: move wrap log_error_and_exit into log_ast_error
f2ae3df
MatiBarcia
MatiBarcia approved these changes Oct 28, 2025
View reviewed changes
Copy link
Collaborator

@MatiBarcia MatiBarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from feat/compiler_builtins to main October 29, 2025 01:02
@LeanSerra LeanSerra marked this pull request as ready for review October 29, 2025 01:02
@LeanSerra LeanSerra merged commit 113610b into main Oct 29, 2025
2 checks passed
@LeanSerra LeanSerra deleted the feat/ast_cleanup branch October 29, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MatiBarcia MatiBarcia MatiBarcia approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LeanSerra @MatiBarcia