feat(BigPictureCustomizer): Adds support for modification of extended layout… #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmarten
approved these changes
Jan 24, 2018
| * push notification. Call bigPictureStyle.bigLargeIcon(largeIconImage) if you want to set large | ||
| * icon on extended push notification. This bigPictureStyle will be set to push notification. Note | ||
| * that if you call bigPictureStyle= new Notification.BigPictureStyle() - there will be no support | ||
| * 2 lines of text and we will show yours extended layout in BigPicture style push notification. |
| * @param bigPictureStyle - Notification.BigPictureStyle or null - BigPicture style for current | ||
| * push notification. Call bigPictureStyle.bigLargeIcon(largeIconImage) if you want to set large | ||
| * icon on extended push notification. This bigPictureStyle will be set to push notification. Note | ||
| * that if you call bigPictureStyle= new Notification.BigPictureStyle() - there will be no support |
Contributor
There was a problem hiding this comment.
bigPictureStyle = new Notification.BigPictureStyle()
| * 2 lines of text and we will show yours extended layout in BigPicture style push notification. | ||
| */ | ||
| void customize(Notification.Builder builder, Bundle notificationPayload); | ||
|
|
| * @param notificationPayload Bundle notification payload. | ||
| * @param bigPictureStyle - Notification.BigPictureStyle or null - BigPicture style for current | ||
| * push notification. Call bigPictureStyle.bigLargeIcon(largeIconImage) if you want to set large | ||
| * icon on extended push notification. This bigPictureStyle will be set to push notification. Note |
|
|
||
| /** | ||
| * Calls setStyle for notificationBuilder and he tries modify notification layout for support 2 | ||
| * lines. |
Contributor
There was a problem hiding this comment.
it tries modify notification layout to support two
| message); | ||
| } else { | ||
| LeanplumPushService.notificationBuilderCustomizer.customize(notificationBuilder, message); | ||
| Notification.BigPictureStyle bigPictureStyle; |
Enuviel
changed the title
Contributor
Author
|
test this please |
1 similar comment
Contributor
Author
|
test this please |
Enuviel
force-pushed
the
feat/feat-LP-8635
branch
from
0c805f3 to
a8e5516
Compare
… layout in BigPictureStyle with 2 lines of text.
Enuviel
force-pushed
the
feat/feat-LP-8635
branch
from
a8e5516 to
b0844dd
Compare
benmarten
reviewed
Jan 25, 2018
| } | ||
| LeanplumPushService.customizer = customizer; | ||
| setCustomizer(customizer, false); | ||
|
|
Contributor
There was a problem hiding this comment.
Hm, I am wondering if we should deprecate it now after all?
It seems to me that this is the method that most clients would want to use now?
Should we also flip the default value to setCustomizer(customizer, false) because then clients would get benefit for 2 lines support, no?
Contributor
Author
|
test this please |
Enuviel
force-pushed
the
feat/feat-LP-8635
branch
from
726225f to
007db0e
Compare
benmarten
approved these changes
Jan 26, 2018
Contributor
benmarten
left a comment
benmarten
left a comment
There was a problem hiding this comment.
this looks solid to me now! thx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(BigPictureCustomizer): Adds support for modification of extended layout in BigPictureStyle with 2 lines of text.