E2-1372 : Add crash handler code #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,5 @@ | |||
| package com.leanplum.monitoring; | |||
|
|
|||
| public interface LeanplumCrashReporting { | |||
Contributor
There was a problem hiding this comment.
let's rename this to ExceptionReporter
| import java.lang.reflect.Constructor; | ||
|
|
||
| public class LeanplumCrashHandler { | ||
| private static final String RAYGUN_CRASH_REPORTER_CLASS = |
Contributor
There was a problem hiding this comment.
RAYGUN_CRASH_REPORTER_CLASS_NAME
| public class LeanplumCrashHandler { | ||
| private static final String RAYGUN_CRASH_REPORTER_CLASS = | ||
| "com.leanplum.monitoring.internal.RaygunCrashReporter"; | ||
| private static final LeanplumCrashHandler ourInstance = new LeanplumCrashHandler(); |
|
|
||
| import java.lang.reflect.Constructor; | ||
|
|
||
| public class LeanplumCrashHandler { |
Contributor
There was a problem hiding this comment.
the class name can be just CrashHandler, it already lives in package com.leanplum.monitoring
|
|
||
| public void setContext(Context context) { | ||
| try { | ||
| Class<?> clazz = Class.forName(RAYGUN_CRASH_REPORTER_CLASS); |
Contributor
There was a problem hiding this comment.
instead of using reflection to try to instantiate the class, we can just let the crash reporter register a factory, if it's loaded by the jvm.
so this CrashHandler can just expose a register method:
static void registerCrashReporterFactory(CrashReporterFactory crashReportFactory) {
reporterFactory = crashReporterFactory;
}
then in setContext()
public void setContext(Context context) {
if (reporterFactory != null) {
crashReporter = crashReporterFactory.create(context);
}
}
Contributor
Author
There was a problem hiding this comment.
Who calls registerCrashReporterFactory ? In my design, the module can just be added and won't need any additional code, hence reflection
Contributor
Author
|
test this please |
1 similar comment
Contributor
Author
|
test this please |
|
|
||
| JSONObject responseBody; | ||
| HttpURLConnection op = null; | ||
|
|
rossenassenov
approved these changes
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Android SDK needs to report crashes. We will add another repo which will provide different crash reporting services to the main repo. This commit adds the interface for a raygun provider