Skip to content

[external] use debug logs instead of info logs #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2022
Merged

[external] use debug logs instead of info logs #518

merged 1 commit into from
Oct 13, 2022

Conversation

@root-ansh
Copy link
Contributor

@root-ansh root-ansh commented Oct 13, 2022

Background

  • ActionManager.java class shows less important logs that floods the info filter. setting the log as debug will allow this log to show up only when verbose filter is enabled

Implementation

  • replaced Log.i with Log.d

Testing steps

  • create a sample app and integrate LeanPlum SDK.
  • launch it on a physical device or emulator
  • log will show up as debug logs instead.

Is this change backwards-compatible?

  • yes

@hborisoff hborisoff merged commit 0f6d8c6 into Leanplum:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hborisoff hborisoff hborisoff approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@root-ansh @hborisoff