Skip to content

fix: data can be null in the downloadMessages response #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2021
Merged

fix: data can be null in the downloadMessages response #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/LeanplumInbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export default class LeanplumInbox implements Inbox {
queued: true,
sendNow: true,
response: (data) => {
const response = data.response[0]
const response = data?.response[0]
if (response && response.newsfeedMessages) {
this.messageMap = response.newsfeedMessages

Expand Down
16 changes: 16 additions & 0 deletions test/specs/LeanplumInbox.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,22 @@ describe(LeanplumInbox, () => {
expect(handler).toHaveBeenCalledTimes(0)
expect(inbox.messageIds()).toEqual([])
})

it('works when reponse is called with null', () => {
const handler = jest.fn()

inbox.onChanged(handler)

createRequestSpy.mockImplementationOnce(
(method, args, options) => {
options.response(null)
}
)
inbox.downloadMessages()

expect(handler).toHaveBeenCalledTimes(0)
expect(inbox.messageIds()).toEqual([])
})
})

describe('allMessages', () => {
Expand Down