Skip to content

fix: ignore session length in dev mode #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2021
Merged

fix: ignore session length in dev mode #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acd9d97
fix: always start sessions in dev mode
gyoshev Oct 29, 2021
26d1299
test: add test
gyoshev Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/LeanplumInternal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ export default class LeanplumInternal {
userAttributes = {}
}

if (this.hasActiveSession()) {
if (this.hasActiveSession() && !this._internalState.devMode) {
return this.startFromCache(userId, userAttributes, callback)
}

Expand Down
17 changes: 17 additions & 0 deletions test/specs/LeanplumInternal.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,23 @@ describe(LeanplumInternal, () => {

expect(lpRequestMock.request).toHaveBeenCalledTimes(3)
})

it('always start new session in dev mode', () => {
lp.setAppIdForDevelopmentMode(APP_ID, KEY_DEV)

let currentTime = 0
jest.spyOn(Date, 'now').mockImplementation(() => currentTime)
lp.useSessionLength(2)

mockNextResponse({ response: [{ success: true }] })
lp.start()

currentTime = 500
mockNextResponse({ response: [{ success: true }] })
lp.start()

expect(lpRequestMock.request).toHaveBeenCalledTimes(2)
})
})
})

Expand Down