Skip to content

Conversation

@milos1290
Copy link
Contributor

No description provided.

}
return result;
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add empty line at the end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, it has empty line on my end.

@@ -1,10 +1,26 @@
//
// LPFileManager.h
// LeanplumTest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to Leanplum

@@ -1,10 +1,26 @@
//
// LPFileManager.m
// LeanplumTest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to Leanplum

+ (NSString *)decipherString:(NSData *)data withKey:(NSString*)cipherKey;

@end
@end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line at the end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, it has empty line on my end.

//
// Created by Andrew First on 9/12/13.
// Copyright 2013 Leanplum, Inc.
//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this file? looks the same but with spaces

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added space for consistency with other license headers.

//
// Created by Andrew First on 4/30/12.
// Copyright (c) 2016 Leanplum. All rights reserved.
// Copyright (c) 2017 Leanplum. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't edit copyright year

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to 2012

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both .h and .m ?

// Leanplum
//
// Created by Andrew First on 4/30/15.
// Copyright (c) 2017 Leanplum. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2015

// Created by Ryan Maxwell on 29/08/13.
// Copyright (c) 2013 Ryan Maxwell. All rights reserved.
// Copyright (c) 2015 Leanplum, Inc. All rights reserved.
// Copyright (c) 2015 Leanplum. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2013

// Created by Ryan Maxwell on 29/08/13.
// Copyright (c) 2013 Ryan Maxwell. All rights reserved.
// Copyright (c) 2015 Leanplum, Inc. All rights reserved.
// Copyright (c) 2015 Leanplum. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2013

Copy link
Contributor

@alexisoyama alexisoyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor detail but why Inc? I think before was okay. Now we need to change all the other files :P Minor detail though.

@benmarten benmarten merged commit 89e023a into develop May 4, 2017
@benmarten
Copy link
Contributor

benmarten commented May 4, 2017

its always Leanplum, Inc
I think these are all orthogonal
(c) 2017 Leanplum, Inc
© 2017 Leanplum, Inc
(c) 2017, Leanplum, Inc
...

@milos1290 milos1290 deleted the feature/license branch May 7, 2017 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants