-
Notifications
You must be signed in to change notification settings - Fork 61
docs(ios): adding license header #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| } | ||
| return result; | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add empty line at the end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, it has empty line on my end.
Leanplum-SDK/Classes/LPFileManager.h
Outdated
| @@ -1,10 +1,26 @@ | |||
| // | |||
| // LPFileManager.h | |||
| // LeanplumTest | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to Leanplum
Leanplum-SDK/Classes/LPFileManager.m
Outdated
| @@ -1,10 +1,26 @@ | |||
| // | |||
| // LPFileManager.m | |||
| // LeanplumTest | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to Leanplum
| + (NSString *)decipherString:(NSData *)data withKey:(NSString*)cipherKey; | ||
|
|
||
| @end | ||
| @end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty line at the end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same, it has empty line on my end.
| // | ||
| // Created by Andrew First on 9/12/13. | ||
| // Copyright 2013 Leanplum, Inc. | ||
| // |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this file? looks the same but with spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added space for consistency with other license headers.
Leanplum-SDK/Classes/Leanplum.m
Outdated
| // | ||
| // Created by Andrew First on 4/30/12. | ||
| // Copyright (c) 2016 Leanplum. All rights reserved. | ||
| // Copyright (c) 2017 Leanplum. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't edit copyright year
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to 2012
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both .h and .m ?
| // Leanplum | ||
| // | ||
| // Created by Andrew First on 4/30/15. | ||
| // Copyright (c) 2017 Leanplum. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2015
Leanplum-SDK/Classes/LPUIAlert.m
Outdated
| // Created by Ryan Maxwell on 29/08/13. | ||
| // Copyright (c) 2013 Ryan Maxwell. All rights reserved. | ||
| // Copyright (c) 2015 Leanplum, Inc. All rights reserved. | ||
| // Copyright (c) 2015 Leanplum. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2013
Leanplum-SDK/Classes/LPUIAlert.h
Outdated
| // Created by Ryan Maxwell on 29/08/13. | ||
| // Copyright (c) 2013 Ryan Maxwell. All rights reserved. | ||
| // Copyright (c) 2015 Leanplum, Inc. All rights reserved. | ||
| // Copyright (c) 2015 Leanplum. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2013
alexisoyama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor detail but why Inc? I think before was okay. Now we need to change all the other files :P Minor detail though.
|
its always |
No description provided.