eql(): fix wrong order of actual vs. expected#56
Merged
rauchg merged 1 commit intoAutomattic:masterfrom Jun 4, 2013
aseemk:patch-1
Merged
eql(): fix wrong order of actual vs. expected#56rauchg merged 1 commit intoAutomattic:masterfrom aseemk:patch-1
rauchg merged 1 commit intoAutomattic:masterfrom
aseemk:patch-1
Conversation
The helper `expect.eql()` function, like typical assertion methods, takes `actual` then `expected`: https://github.com/LearnBoost/expect.js/blob/master/expect.js#L850 But the `Assertion.prototype.eql` wrapper has been incorrectly passing `this.obj` (the object being tested) as the `expected`, and vice versa passing `obj` (the object used for comparison) as the `actual`. This fixes that.
| @@ -1,4 +1,3 @@ | |||
|
|
|||
Contributor
Author
There was a problem hiding this comment.
Sorry, I didn't mean to do this. I used GitHub's online editor; it must have done this automatically.
rauchg
added a commit
that referenced
this pull request
Jun 4, 2013
eql(): fix wrong order of actual vs. expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The helper
expect.eql()function, like typical assertion methods,takes
actualthenexpected:https://github.com/LearnBoost/expect.js/blob/master/expect.js#L850
But the
Assertion.prototype.eqlwrapper has been incorrectlypassing
this.obj(the object being tested) as theexpected, andvice versa passing
obj(the object used for comparison) as theactual. This fixes that.