Fixing xhr(-polling) under node.js

[fourplusone]

on nodejs global.location.protocol is not present, so XHR.check always fails.

[rauchg]

haha so random that the try{}catch{} makes it not fail… great catch

Shouldn't we do a

// if node
return true;
// end node

at the top instead ? Since we don't really need cross-domain checks in node

[fourplusone]

Would be ok too

[rauchg]

Yeah let's do it

[fourplusone]

Anything that still needs to be done before merging?

[kafouros]

Hi there. Are you planning to release this fix soon? Thanks in advance.

[thatguydan]

+1 please, should add that heroku required xhr-polling transport only, which means without the fix the library can't be used to talk to heroku hosted socket.io

[askpete]

it would be a big help to get this released so we can use it with npm

[schappim]

+1

[mfrobben]

Bump - theres 12 people on an associated error thread waiting for fixes to the eventual crash this bug can cause in node / heroku.