Statement forwarding now decodes &46; to . #1134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ht2
requested changes
Apr 11, 2018
Contributor
ht2
left a comment
ht2
left a comment
There was a problem hiding this comment.
@cbishopvelti Could we use the mapDot method in the statement model to map over the object's keys, ensuring that no actual values that happen to have &46; get converted?
Contributor
ht2
approved these changes
Apr 16, 2018
ht2
added a commit
that referenced
this pull request
Apr 18, 2018
### Added - Multiple shareable links per dashboard (#1096) - Requires migration to be run - `yarn migrate` - Aggregations now can read from secondary members on replica set (#1095) - Sentinel Redis support (#1119) - New role to allow organisation creation (via site admin) (#1110) - Widgets now auto pick visualisation name when populated (#1126) ### Security - Passwords can only be changed for the user logged in or by site admins (#1112) ### Fixes - Unicode data now pulled from dependency (#1125) - Ensure order on personaIdentifier IFI values (fixes issue with multiple personaIdents for the same actor) (#1120) - Fix for personaIdentifier migration - Client can select more than 10 xAPI stores (#1130) - Server side validation of Statement Forward queries (#1138) - Statement forwards decode `&46;` in statement keys (#1134) - Fixed issue with hanging file imports on persona data (#1141) - Switch to `clamdscan` as primary AV scanner (#1141) - Requires updated .env settings - refer to .env.example ### Performance and build - Webpack 3 - improved build speed (#1094) ### Migrations **This update requires a migration which can be run using `yarn migrate`.**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.