feat(Mongo): Update xAPI service to use mongodb node.js driver v4 (LLC-1689) #862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json # src/apps/activities/mongoAuthRepo/tests/getClient.test.ts # src/apps/agents/mongoAuthRepo/tests/getClient.test.ts # src/apps/statements/expressPresenter/utils/getUrlPath.ts # src/apps/statements/repo/authRepo/getClient/mongo.test.ts # src/apps/statements/tests/storingStatements/attachments.test.ts # src/apps/states/mongoAuthRepo/tests/getClient.test.ts # yarn.lock
Codecov ReportBase: 89.37% // Head: 94.25% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #862 +/- ##
==========================================
+ Coverage 89.37% 94.25% +4.87%
==========================================
Files 652 652
Lines 7079 7102 +23
Branches 758 789 +31
==========================================
+ Hits 6327 6694 +367
+ Misses 669 286 -383
- Partials 83 122 +39
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lydiamross
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
LGTM! 🚀
Agree that these seem to be the only workaround for the weird behaviour of findOneAndUpdate()
|
🎉 This PR is included in version 6.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes LLC-1689