Optimize ParcelDiffHelper #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
commented
Apr 25, 2022
Comment on lines
+19
to
+30
| private fun <T : Parcelable> T.deepCopy(): T? { | ||
| var parcel: Parcel? = null | ||
| return try { | ||
| parcel = Parcel.obtain().also { | ||
| it.writeParcelable(this, 0) | ||
| it.setDataPosition(0) | ||
| } | ||
| parcel.readParcelable(this::class.java.classLoader) | ||
| } finally { | ||
| parcel?.recycle() | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
这种深拷贝实现更具有普适性吧，entity.javaClass.getDeclaredConstructor(Parcel::class.java) 那里会在用了 kotlin-parcelize 插件之后抛异常的，因为没有那个构造器
Owner
There was a problem hiding this comment.
估计当时写的时候是没考虑kotlin-parcelize 我觉得可以啊 这么改
Contributor
Author
There was a problem hiding this comment.
其实一般场景下用 data class 的 copy 就好了，完全深拷贝不是很有必要
| } | ||
| itemsCursor?.run { | ||
| snapshot = CopyOnWriteArrayList() | ||
| forEach { |
Contributor
Author
There was a problem hiding this comment.
用了 deepCopy 的扩展之后没必要异常处理了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.