Skip to content
This repository was archived by the owner on Dec 1, 2024. It is now read-only.

Commit 334af2c

Browse files
committed
Restore RocksDB test specifics
1 parent 3843dc0 commit 334af2c

File tree

6 files changed

+17
-20
lines changed

6 files changed

+17
-20
lines changed

test/destroy-test.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,8 @@ test('test destroy non-existent parent directory', function (t) {
5656
t.notOk(fs.existsSync(parent), 'parent does not exist before')
5757

5858
leveldown.destroy(location, function (err) {
59-
t.error(err, 'no error')
59+
// This behavior differs from LevelDB, which is silent.
60+
t.ok(/.*IO error.*\/1\/2\/3\/4\/LOCK.*/.test(err), 'got IO error')
6061
t.notOk(fs.existsSync(location), 'directory does not exist after')
6162
})
6263
})

test/getproperty-test.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,28 +28,28 @@ test('test non-string getProperty() throws', function (t) {
2828

2929
test('test invalid getProperty() returns empty string', function (t) {
3030
t.equal(db.getProperty('foo'), '', 'invalid property')
31-
t.equal(db.getProperty('leveldb.foo'), '', 'invalid leveldb.* property')
31+
t.equal(db.getProperty('rocksdb.foo'), '', 'invalid rocksdb.* property')
3232
t.end()
3333
})
3434

35-
test('test invalid getProperty("leveldb.num-files-at-levelN") returns numbers', function (t) {
35+
test('test invalid getProperty("rocksdb.num-files-at-levelN") returns numbers', function (t) {
3636
for (var i = 0; i < 7; i++) {
37-
t.equal(db.getProperty('leveldb.num-files-at-level' + i),
38-
'0', '"leveldb.num-files-at-levelN" === "0"')
37+
t.equal(db.getProperty('rocksdb.num-files-at-level' + i),
38+
'0', '"rocksdb.num-files-at-levelN" === "0"')
3939
}
4040
t.end()
4141
})
4242

43-
test('test invalid getProperty("leveldb.stats")', function (t) {
44-
t.ok(db.getProperty('leveldb.stats').split('\n').length > 3, 'leveldb.stats has > 3 newlines')
43+
test('test invalid getProperty("rocksdb.stats")', function (t) {
44+
t.ok(db.getProperty('rocksdb.stats').split('\n').length > 3, 'rocksdb.stats has > 3 newlines')
4545
t.end()
4646
})
4747

48-
test('test invalid getProperty("leveldb.sstables")', function (t) {
48+
test('test invalid getProperty("rocksdb.sstables")', function (t) {
4949
var expected = [0, 1, 2, 3, 4, 5, 6].map(function (l) {
50-
return '--- level ' + l + ' ---'
50+
return '--- level ' + l + ' --- version# 1 ---'
5151
}).join('\n') + '\n'
52-
t.equal(db.getProperty('leveldb.sstables'), expected, 'leveldb.sstables')
52+
t.equal(db.getProperty('rocksdb.sstables'), expected, 'rocksdb.sstables')
5353
t.end()
5454
})
5555

test/leak-tester-batch.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ function print () {
1818
Math.round(process.memoryUsage().rss / rssBase * 100) + '%',
1919
Math.round(process.memoryUsage().rss / 1024 / 1024) + 'M',
2020
JSON.stringify([0, 1, 2, 3, 4, 5, 6].map(function (l) {
21-
return db.getProperty('leveldb.num-files-at-level' + l)
21+
return db.getProperty('rocksdb.num-files-at-level' + l)
2222
}))
2323
)
2424
}

test/leak-tester.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ function run () {
3535
Math.round(process.memoryUsage().rss / rssBase * 100) + '%',
3636
Math.round(process.memoryUsage().rss / 1024 / 1024) + 'M',
3737
JSON.stringify([0, 1, 2, 3, 4, 5, 6].map(function (l) {
38-
return db.getProperty('leveldb.num-files-at-level' + l)
38+
return db.getProperty('rocksdb.num-files-at-level' + l)
3939
})))
4040
}
4141
}

test/port-libuv-fix-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ const test = require('tape')
22
const path = require('path')
33
const fs = require('fs')
44

5-
test('test port-libuv is being used', function (t) {
5+
test.skip('test port-libuv is being used', function (t) {
66
var version = fs.readFileSync(path.join(__dirname, '../deps/leveldb/leveldb.gyp'), 'utf8')
77
.match(/"ldbversion": "([^"]+)"/)[1]
88
var porth

test/repair-test.js

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,7 @@ test('test callback-less, 1-arg, repair() throws', function (t) {
2121

2222
test('test repair non-existent directory returns error', function (t) {
2323
leveldown.repair('/1/2/3/4', function (err) {
24-
if (process.platform !== 'win32') {
25-
t.ok(/no such file or directory/i.test(err), 'error on callback')
26-
} else {
27-
t.ok(/IO error/i.test(err), 'error on callback')
28-
}
24+
t.ok(/^Error: NotFound:/i.test(err), 'error on callback')
2925
t.end()
3026
})
3127
})
@@ -39,14 +35,14 @@ makeTest('test repair() compacts', function (db, t, done) {
3935

4036
var files = fs.readdirSync(location)
4137
t.ok(files.some(function (f) { return (/\.log$/).test(f) }), 'directory contains log file(s)')
42-
t.notOk(files.some(function (f) { return (/\.ldb$/).test(f) }), 'directory does not contain ldb file(s)')
38+
t.notOk(files.some(function (f) { return (/\.sst$/).test(f) }), 'directory does not contain sst file(s)')
4339

4440
leveldown.repair(location, function (err) {
4541
t.ifError(err, 'no error from repair()')
4642

4743
files = fs.readdirSync(location)
4844
t.notOk(files.some(function (f) { return (/\.log$/).test(f) }), 'directory does not contain log file(s)')
49-
t.ok(files.some(function (f) { return (/\.ldb$/).test(f) }), 'directory contains ldb file(s)')
45+
t.ok(files.some(function (f) { return (/\.sst$/).test(f) }), 'directory contains sst file(s)')
5046

5147
done(null, false)
5248
})

0 commit comments

Comments
 (0)