Skip to content
This repository was archived by the owner on Dec 1, 2024. It is now read-only.

Disable info log by default and add infoLogLevel option#114

Merged
vweevers merged 1 commit intomasterfrom
disable-info-log
May 30, 2019
Merged

Disable info log by default and add infoLogLevel option#114
vweevers merged 1 commit intomasterfrom
disable-info-log

Conversation

@vweevers
Copy link
Copy Markdown
Member

Closes #113.

Benchmarks show that this doesn't improve write performance (with the info log enabled, there's a small amount of logs being written on every compaction). It does however fix the destroy() bug on Windows in a cleaner way, and prevents endlessly growing logs that you didn't ask for (cc @MeirionHughes).

git checkout disable-info-log
level-bench run write -b [-n 2e6 --concurrency 10]
level-bench run write -b [-n 2e6 --concurrency 10] --db [--infoLogLevel debug]
level-bench plot write

write 1558886671306

@vweevers vweevers added the cleanup Housekeeping label May 26, 2019
@vweevers vweevers requested review from peakji and ralphtheninja May 26, 2019 16:30
@vweevers
Copy link
Copy Markdown
Member Author

@ralphtheninja @peakji Is either of you able to review this week or next week? This PR is the last thing I want to get in before releasing 4.0.0 (disabling the info log could be considered a breaking change).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cleanup Housekeeping

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable info logs by default

3 participants