This repository was archived by the owner on Dec 1, 2024. It is now read-only.
Disable info log by default and add infoLogLevel option#114
Merged
Conversation
Member
Author
|
@ralphtheninja @peakji Is either of you able to review this week or next week? This PR is the last thing I want to get in before releasing 4.0.0 (disabling the info log could be considered a breaking change). |
ralphtheninja
approved these changes
May 29, 2019
peakji
approved these changes
May 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #113.
Benchmarks show that this doesn't improve write performance (with the info log enabled, there's a small amount of logs being written on every compaction). It does however fix the
destroy()bug on Windows in a cleaner way, and prevents endlessly growing logs that you didn't ask for (cc @MeirionHughes).