Update abstract-leveldown to the latest version 🚀 by greenkeeper[bot] · Pull Request #77 · Level/rocksdb

greenkeeper · 2018-10-20T12:54:25Z

The dependency abstract-leveldown was updated from `5.0.0` to `6.0.0`.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

Release Notes for v6.0.0

If you are upgrading, please consult the Upgrade Guide.

Changed

Upgrade airtap devDependency from 0.0.5 to 0.1.0 (#229, #231, #245, 029f56a, #252) (@vweevers, @ralphtheninja)
Upgrade sinon devDependency from ^5.0.0 to ^6.0.0 (#232) (@ralphtheninja)
Upgrade standard devDependency from ^11.0.0 to ^12.0.0 (#303) (@ralphtheninja)
Reject nullish values (#277) (@vweevers)
Make default _serializeKey and _serializeValue identity functions (#277) (@vweevers)
Don't coerce keys to strings to check if they're empty, instead check arrays explicitly (#277) (@vweevers)
Make db property mandatory and public on iterator and chained batch (#257, #309) (@vweevers)
Align AbstractChainedBatch#_clear with _put and _del (#257) (@vweevers)
Add AbstractChainedBatch#_write with options (#257) (@vweevers)
Use level-concat-iterator instead of collectEntries (#246) (@ralphtheninja)
Document API and test suite (#251, #290, #295, #296, #305) (@vweevers)
Export test suite as a single function (#271, #293, #297) (@vweevers, @ralphtheninja)
Use factory function to create db instances in test suite (#258, #268, #282) (@ralphtheninja, @vweevers)
Isolate snapshot tests so that they can be skipped (#239, #274) (@vweevers, @ralphtheninja)
Isolate openAdvanced tests so that they can be skipped (#271) (@vweevers)
Rename abstract/ to test/ (#253) (@vweevers)
Refactor internal test methods to have the same signature (test, testCommon) (#268, #275) (@ralphtheninja)
Prefer exports.* over module.exports.* (#276) (@ralphtheninja)
Tweak copyright years for less maintenance (0b2949a) (@ralphtheninja)

Added

Add iterator#seek() (#237, #302, #307) (@vweevers, @ralphtheninja)
Add nyc and coveralls devDependencies for code coverage (#253) (@vweevers)
Add setUp and tearDown to all sub tests (#279, #289) (@ralphtheninja)
Add test for implementations that cannot support snapshots (#239) (@vweevers)
Add hallmark devDependency for Markdown style and contributors (#312) (@vweevers)

Removed

Remove location (#258) (@ralphtheninja)
Remove lastLocation, cleanup, rimraf (#249) (@vweevers)
Remove IE10 from Sauce Labs test matrix (#312) (@vweevers)
Remove node 9 from Travis (0b52395) (@ralphtheninja)
Remove tests that assumed support of boolean and NaN keys (#277) (@vweevers)
Remove range tests that assumed null meant "not defined" (#277) (@vweevers)
Remove sync test from test/put-test.js (#300) (@ralphtheninja)
Remove empty errorValues() test (#273) (@ralphtheninja)
Remove default testCommon parameter (#264, #271) (@vweevers)
Remove contributors from package.json (542f350) (@ralphtheninja)
Remove copyright headers from code (a36c04f) (@ralphtheninja)

Fixed

Make sure all t.throw tests check error messages correctly (#286) (@ralphtheninja)
Check options objects properly for null (#257, #288) (@ralphtheninja, @vweevers)
Serialize range options same as keys (#277) (@vweevers)
Allow nullish and empty range options (#277) (@vweevers)

Commits

The new version differs by 54 commits.

af12348 6.0.0
17328ce Prepare 6.0.0 (#312)
5b4c550 Make db property mandatory and public on iterator and chained batch (#309)
b610da0 Import seek tests from leveldown (#307)
e7285bb readme: undefined behavior for nullish range options is legit (#305)
0f42686 Merge pull request #303 from Level/greenkeeper/standard-12.0.0
1170cea chore(package): update standard to version 12.0.0
a6c733b Fix bug in AbstractIterator#_seek (#302)
aeabe99 Remove sync test (#300)
51af868 Add 'bufferKeys' and 'seek' to skip options (#297)
76f0477 add Spread The Word and Install sections (#296)
6311fae add test suite documentation (#295)
adac630 Update upgrade guide [wip] (#272)
e8415d5 Update changelog for v6 (#291)
a8aa1c2 Merge testCommon and test options (#293)

There are 54 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper bot 🌴

Closes #77

vweevers · 2019-04-07T10:47:27Z

Luckily I could cherry pick almost everything from leveldown.

Closes #77

* Handle location in constructor at it was removed from abstract-leveldown * Pass a factory function to abstract tests * Use tempy in tests, removing need for cleanup * Use level-concat-iterator in tests

* Invoke abstract tests from single function * Options is actually now passed as options from abstract-leveldown and not a function

With undefined behavior for nullish targets (range options and seek targets). Previously, nullish range options were ignored and seek(null) and seek(undefined) would throw an error. Now they translate to String(null) and String(undefined). This change makes it explicit that rocksdb only supports buffers and strings. Nullish targets do have a meaning in the ecosystem; that meaning should be given at a higher level like encoding-down. In other words, it isn't rocksdb's concern anymore.

* Restore (but skip) segfault test from abstract-leveldown * Prevent segfault when calling iterator() on non-open db

* make callback of makeTest an error-first callback * normalize error assertions in tests that use makeTest

* handle errors in compactRange test * use batch() in compactRange test * serialize compactRange() start and end * copy type checks from approximateSize to compactRange

vweevers · 2019-04-26T15:42:01Z

@peakji Could you review the last commit here (dd18a98)? 🙏

I'm fairly confident about the rest.

peakji · 2019-04-26T15:45:51Z

@vweevers 👌

peakji · 2019-04-26T16:03:45Z

@vweevers I've reviewed batch.h, batch.cc, batch_async.h, batch_async.cc, and related parts in database.cc. LGTM!

greenkeeper bot added the dependencies Pull requests that update a dependency file label Oct 20, 2018

greenkeeper bot added a commit that referenced this pull request Dec 27, 2018

fix(package): update abstract-leveldown to version 6.0.1

b0175c3

Closes #77

This comment has been minimized.

Sign in to view

vweevers mentioned this pull request Dec 28, 2018

Update level-packager to the latest version 🚀 Level/level-rocksdb#53

Closed

vweevers added the semver-major Changes that break backward compatibility label Jan 1, 2019

greenkeeper bot added a commit that referenced this pull request Mar 30, 2019

fix(package): update abstract-leveldown to version 6.0.2

1e76a24

Closes #77

This comment has been minimized.

Sign in to view

vweevers force-pushed the greenkeeper/abstract-leveldown-6.0.0 branch from 0abfde8 to 4718274 Compare April 7, 2019 10:40

vweevers requested review from peakji and ralphtheninja April 7, 2019 10:51

vweevers mentioned this pull request Apr 7, 2019

Prepare next #103

Merged

greenkeeper bot added a commit that referenced this pull request Apr 26, 2019

fix(package): update abstract-leveldown to version 6.0.3

907d65c

Closes #77

This comment has been minimized.

Sign in to view

vweevers self-assigned this Apr 26, 2019

greenkeeper bot and others added 13 commits April 26, 2019 17:28

Upgrade abstract-leveldown from ~5.0.0 to ~6.0.3

e6f9613

Import and fix GC test from levelup

2beee00

Remove redundant db.close() from test/approximate-size-test.js

ad2f834

Update handling of location

5fa429a

* Handle location in constructor at it was removed from abstract-leveldown * Pass a factory function to abstract tests * Use tempy in tests, removing need for cleanup * Use level-concat-iterator in tests

Invoke abstract tests from single function

1e53765

* Invoke abstract tests from single function * Options is actually now passed as options from abstract-leveldown and not a function

Use suite.common() in test/common.js

c68a141

Implement abstract _seek() instead of seek()

2681961

Moved seek tests to abstract-leveldown

e54fcf2

Remove unused iota-array and lexicographic-integer devDependencies

1341e5d

Add segfault tests

e99e12f

* Restore (but skip) segfault test from abstract-leveldown * Prevent segfault when calling iterator() on non-open db

Remove unused 'key' argument from ChainedBatch#_clear

27bed20

Make callback of makeTest an error-first callback

cacddad

* make callback of makeTest an error-first callback * normalize error assertions in tests that use makeTest

vweevers and others added 8 commits April 26, 2019 17:28

Serialize compactRange() arguments

61f59e2

* handle errors in compactRange test * use batch() in compactRange test * serialize compactRange() start and end * copy type checks from approximateSize to compactRange

Remove 32 bits from appveyor

f65d0bf

Remove xcacheSize and xmaxOpenFiles from leak tests

ce2f696

Remove slump devDependency

ef4af1d

Remove outdated benchmarks altogether

0ea7a85

Use tempy in open-read-only-test

c50d820

Update comment in segfault-test

31f83a6

Fix asynchronicity of empty chained batch

dd18a98

vweevers force-pushed the greenkeeper/abstract-leveldown-6.0.0 branch from 4718274 to dd18a98 Compare April 26, 2019 15:36

vweevers removed their assignment Apr 26, 2019

peakji approved these changes Apr 26, 2019

View reviewed changes

vweevers merged commit 51b97f7 into master Apr 26, 2019

vweevers deleted the greenkeeper/abstract-leveldown-6.0.0 branch April 26, 2019 17:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update abstract-leveldown to the latest version 🚀#77

Update abstract-leveldown to the latest version 🚀#77
vweevers merged 21 commits intomasterfrom
greenkeeper/abstract-leveldown-6.0.0

greenkeeper bot commented Oct 20, 2018

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vweevers commented Apr 7, 2019

Uh oh!

This comment has been minimized.

This comment has been minimized.

vweevers commented Apr 26, 2019

Uh oh!

peakji commented Apr 26, 2019

Uh oh!

peakji commented Apr 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

greenkeeper bot commented Oct 20, 2018

The dependency abstract-leveldown was updated from 5.0.0 to 6.0.0.

Changed

Added

Removed

Fixed

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vweevers commented Apr 7, 2019

Uh oh!

This comment has been minimized.

This comment has been minimized.

vweevers commented Apr 26, 2019

Uh oh!

peakji commented Apr 26, 2019

Uh oh!

peakji commented Apr 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

The dependency abstract-leveldown was updated from `5.0.0` to `6.0.0`.