Feature/better h0 support #537
Conversation
|
|
||
| for i in avail_worker_ids(W): | ||
| # Give sim work | ||
| sim_work(Work, i, sim_specs['in'], [persis_info['next_to_give']], []) |
There was a problem hiding this comment.
Should it check 'given' for the row its on - and increment if True?
There was a problem hiding this comment.
Yes. That is possible. This allocation function is called give_pregenerated_sample so I think that it's okay to just go through all of the rows of H in order. (But I'm fine with checking given.)
Note that the top of this allocation function is not very robust: If there is persis_info then next_to_give will not be initialized. I hope that such issues will be addressed in our re-working of allocation functions.
There was a problem hiding this comment.
Should it just be checking the 'next_to_give' component is initialized? Something like:
persis_info['next_to_give'] = persis_info.get('next_to_give', 0) + 1
There was a problem hiding this comment.
The initialization is fixed in 8080b1b
There was a problem hiding this comment.
Thank you for the feedback!
Pull Request Test Coverage Report for Build 4237
💛 - Coveralls |
3 participants
Before
H0was assumed to contain only points withgivenandreturnedasTrue.A way to do simulation evaluations at some pre-existing set of points is to put them into
H0and have analloc_fgive them out (without needed agen_fcall).In this regression test, libEnsemble was marking them as
givenandreturnedbut thealloc_fwas giving them out anyway (so the test was performing correctly).