Skip to content

Conversation

jlnav
Copy link
Member

@jlnav jlnav commented Sep 27, 2021

No description provided.

…tent func lifetime. removes alloc_specs['in']. refactors many funcs and tests for changes
@jlnav jlnav requested review from jmlarson1 and shuds13 September 27, 2021 18:22
@coveralls
Copy link
Collaborator

coveralls commented Sep 27, 2021

Pull Request Test Coverage Report for Build 1283944417

  • 16 of 16 (100.0%) changed or added relevant lines in 7 files are covered.
  • 176 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-1.8%) to 91.257%

Files with Coverage Reduction New Missed Lines %
libensemble/gen_funcs/persistent_deap_nsga2.py 1 98.35%
libensemble/gen_funcs/persistent_surmise_calib.py 1 97.59%
libensemble/tools/consensus_subroutines.py 4 95.5%
libensemble/tools/gen_support.py 21 0%
libensemble/gen_funcs/persistent_gp.py 61 0%
libensemble/executors/balsam_executor.py 88 34.36%
Totals Coverage Status
Change from base Build 1270398337: -1.8%
Covered Lines: 6113
Relevant Lines: 6615

💛 - Coveralls

@jlnav jlnav changed the title Adds persis_in, removes alloc_specs['in'], various small refactors Adds persis_in, removes alloc_specs['in'], various small refactors Sep 27, 2021
persis_info['fields_to_give_back'] = ['f'] + [n[0] for n in gen_specs['out']]
persis_info['fields_to_give_back'] = gen_specs['persis_in']

if 'grad' in [n[0] for n in sim_specs['out']]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmlarson1 @jlnav Do we want to construct fields to give back like this - or expect the user to do it in calling script when creating gen_specs['persis_in'] ? An alloc could support a default, if the user does not set persis_in maybe, but seems to me potentially confusing to mix user supplied and add to it in alloc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'd lean towards expecting the user to define their fields in their calling script. I think I was more explicit with all the other cases except the new functions from the student.

Any major objections to refactoring the above conditional fields to be in their corresponding calling scripts instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think that we should expect the user to define their fields in their calling script.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@jlnav jlnav merged commit 0c6160d into develop Sep 28, 2021
@jlnav jlnav deleted the feature/persis_in branch September 28, 2021 19:45
@shuds13 shuds13 mentioned this pull request Oct 8, 2021
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants