Feature/improved libE field naming

[jmlarson1]

These new fields have many positives:

• They align with sim_f and gen_f and sim_specs and gen_specs and the like.
• Many of the old entries were ambiguous: It is not clear what given is referring to. The recipient of given_back is unclear.
• They tell a "story" about the entry in H.

1. The point is generated by gen_worker between gen_started_time and gen_ended_time.
2. It is given to sim_worker and sim_given is marked true and sim_given_time is recorded
3. When sim_worker is done, sim_completed is marked true, and sim_completed_time is recorded.
4. If the gen_worker is informed about the point, then gen_informed is marked true and gen_informed_time is recorded.

We'd remove distinction of last_gen_time being different from gen_time.

The following crosswalk can help any users with gens/sims/allocs using these fields in H

• last_gen_time/gen_time -> gen_ended_time
• given -> sim_started
• given_time -> sim_started_time
• returned -> sim_ended
• returned_time -> sim_ended_time
• given_back -> gen_informed
• gen_back_time -> gen_informed_time

Also, we will add gen_started_time as this would be needed (for example) to cancel long-running gens.

[wildsm]

This looks great.

[jlnav]

This file still needs to be adjusted, right?

[jmlarson1]

Thanks! I have updated this file.

[jmlarson1]

@jlnav @shuds13

Angel gave some feedback on this. While he said that he doesn't use these fields much, he thought that sim_started is a more intuitive name for a boolean than than sim_start. I think that "agrees" with gen_informed and cancel_requested as things that would be True/False.

I agree with Angel. Please give thoughts on the current state of libensemble/tools/fields_keys.py

[jlnav]

Good feedback from Angel, I like the current state of fields_keys.py. Understanding the "story" of a point is (I think) more intuitive now

[jlnav]

Just realizes this also addresses #525 !

edit: and #593 ?