Miscellaneous build system patches #201
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configures have a shebang of #!/bin/sh so need to work with a POSIX-compliant shell; let's use = instead of == which will have the same effect on both Bash and said shells (like dash). Signed-off-by: Sam James <sam@gentoo.org>
salcock
reviewed
Feb 8, 2022
|
Everything looks great to me -- thanks for contributing these changes back. Just waiting on confirmation that my concerns about that comment are legit, then I'll be happy to accept this PR. |
|
(Will check tomorrow, thank you!) |
This avoids an 'automagic dependency' [0] on NUMA. This is helpful for downstreams to ensure we don't miss dependencies or when we may not want to enable support for a feature even though a dependency is enabled. Gentoo has shipped this patch for quite some time. [0] https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Automagic_dependencies Signed-off-by: Sam James <sam@gentoo.org>
ncurses can be built in a variety of configurations, but the motivating case for Gentoo was "split tinfo" where libtinfo is no longer included within libncurses. Use pkg-config to find where ncurses is installed and the required libraries needed to link against it (which will include -ltinfo if required). We've been shipping this patch in Gentoo for quite some time. Signed-off-by: Sam James <sam@gentoo.org>
|
This all looks good to me -- I've merged this PR into our Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstreaming the patches we've been carrying in Gentoo: