Skip to content

Conversation

@deependujha
Copy link
Collaborator

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #178

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@deependujha deependujha marked this pull request as draft July 4, 2024 12:01
@deependujha
Copy link
Collaborator Author

Sorry, didn't even tested in rush. Some tests based on file serializer are failing. Fixing them quickly.

@codecov
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@6ebb7b9). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             main   #207   +/-   ##
=====================================
  Coverage        ?    77%           
=====================================
  Files           ?     33           
  Lines           ?   4669           
  Branches        ?      0           
=====================================
  Hits            ?   3585           
  Misses          ?   1084           
  Partials        ?      0           

@deependujha deependujha marked this pull request as ready for review July 5, 2024 10:32
Copy link
Collaborator

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work !

@tchaton tchaton merged commit 5779bcb into Lightning-AI:main Jul 5, 2024
@deependujha deependujha deleted the fix/magic-serializer-issue branch July 5, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Magic FileSerializer is causing issues

2 participants