Skip to content

Conversation

@lud-ds
Copy link
Contributor

@lud-ds lud-ds commented Jul 17, 2024

Error message refers to output_dir.path instead of output_dir.url

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Error message refers to output_dir.path instead of output_dir.url
@lud-ds lud-ds requested review from awaelchli and tchaton as code owners July 17, 2024 14:29
@codecov
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@5d6b8f9). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             main   #239   +/-   ##
=====================================
  Coverage        ?    77%           
=====================================
  Files           ?     33           
  Lines           ?   4696           
  Branches        ?      0           
=====================================
  Hits            ?   3622           
  Misses          ?   1074           
  Partials        ?      0           

@tchaton tchaton merged commit 44b8a40 into Lightning-AI:main Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants