Skip to content

Conversation

@csy1204
Copy link
Contributor

@csy1204 csy1204 commented Jul 23, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

  • Adjusted the code to handle cases where the 'encryption' field is missing in the dataset, preventing errors from occurring.

Fixes #258

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@ce0240c). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             main   #259   +/-   ##
=====================================
  Coverage        ?    78%           
=====================================
  Files           ?     34           
  Lines           ?   4873           
  Branches        ?      0           
=====================================
  Hits            ?   3784           
  Misses          ?   1089           
  Partials        ?      0           

@tchaton tchaton merged commit 27ba2ef into Lightning-AI:main Jul 23, 2024
@csy1204 csy1204 deleted the fix/pass-encryption branch July 23, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support backward compatibility for optimized dataset without encryption field (0.2.14)

2 participants