-
Notifications
You must be signed in to change notification settings - Fork 79
[experiment] ci: xdist increase number of processes #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #681 +/- ##
===================================
Coverage 84% 84%
===================================
Files 52 52
Lines 7021 7021
===================================
+ Hits 5900 5902 +2
+ Misses 1121 1119 -2 🚀 New features to boost your workflow:
|
Result with
|
| OS & Python Version | main: -n 2 |
PR: -n 3 |
|---|---|---|
macos-14: py: 3.09 |
26m 02s | 19m 19s |
macos-14: py: 3.10 |
29m 33s | 23m 46s |
macos-14: py: 3.11 |
28m 51s | 22m 24s |
ubuntu (4 cpu in CI)
very similar, no significant difference
| OS & Python Version | main: -n 2 |
PR: -n 3 |
|---|---|---|
ubuntu-22.04: py: 3.09 |
27m 50s | 27m 53s |
ubuntu-22.04: py: 3.10 |
26m 48s | 26m 38s |
ubuntu-22.04: py: 3.11 |
27m 16s | 27m 19s |
ubuntu-22.04: py: 3.12 |
31m 26s | 33m 23s |
ubuntu-22.04: py: 3.13 |
26m 34s | 26m 53s |
my bad, earlier I said, github ci has 2 cpus, and my logic was:
CORES=$(python -c "import os; print(max(1, os.cpu_count() // 2))")
echo "Using $CORES cores for pytest"I forgot about /2 and said github ci has 2 cpus. :)
- ubuntu & windows have 4 cpus (cores)
- mac: 3 cpus
cc: @Borda
|
btw, seems to be a bit flaky on Windows: |
|
Changing to Next, I think we might need to look into the ignored tests for parallel execution and also improve performance at the test level, especially based on the latest top 100 test timing results. On Windows, some tests take over 200 seconds, and other runtimes have several tests above 60 seconds. |
so let's close this experiment |
Before submitting
What does this PR do?
Fixes # (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃